Skip to content

tweak env/reqs to utilize latest version(s) of PCMDI/cmor #707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ilaflott merged 8 commits into from
Jan 31, 2026
Merged

tweak env/reqs to utilize latest version(s) of PCMDI/cmor #707

ilaflott merged 8 commits into from
Jan 31, 2026
+218 −162

Conversation

@ilaflott
Copy link
Member

@ilaflott ilaflott commented Jan 29, 2026 •
edited
Loading

Describe your changes

  • python version is now allowed to be >=3.11, we currently seem to be comfortably landing on 3.12
  • cmor version is now 3.14 or greater
  • noaa-gfdl::fre-nctools removed from all requirements, tests requiring it now check for the appropriate executables using shutil.which
  • python, pip, setuptools and wheel all needed to be specified in requirements: build: for meta.yaml to avoid a build issue on more recent python/conda versions that we are now starting to develop compatibility for
  • some light clean up in test files that i needed to keep an eye on for failures
  • certain messages produced upon failing assert checks were added and/or tweaked to be more helpful
  • also a minor docstring or two added
  • documentation generally updated as minimally as possible where applicable

Issue ticket number and link (if applicable)

see Development tab on the right side of this PR screen

Checklist before requesting a review

  • I ran my code
  • I tried to make my code readable
  • I tried to comment my code
  • [ ] I wrote a new test, if applicable
  • I wrote new instructions/documentation, if applicable
  • I ran pytest and inspected it's output
  • I ran pylint and attempted to implement some of it's feedback
  • No print statements; all user-facing info uses logging module

@ilaflott ilaflott mentioned this pull request Jan 29, 2026
Open
@ilaflott ilaflott changed the title tweak versions, lets see what happens to env resolution tweak env/reqs to utilize latest version(s) of PCMDI/cmor Jan 30, 2026
@ilaflott
Copy link
Member Author

ilaflott commented Jan 30, 2026

currently failing? oui, but given that environment creation for fre-cli has taken basically >5 minutes for a long time, the current env creation step is now taking <2 minutes

This was linked to issues Jan 30, 2026
remove noaa-gfdl::fre-nctools requirement from fre-cli #709
Closed
noaa-gfdl::fre-nctools==2022.02.01 requirement caps libnetcdf to 4.9.2 #708
Open
@ilaflott ilaflott added bug Something isn't working clean up priority: HIGH labels Jan 30, 2026
@ilaflott ilaflott self-assigned this Jan 30, 2026
@ilaflott ilaflott linked an issue Jan 30, 2026 that may be closed by this pull request
fre.cmor: adjust environment requirements and enable cmor>3.11 compatibility #663
Closed
@ilaflott
Copy link
Member Author

ilaflott commented Jan 30, 2026

this will close #663 because it will close #709 . it will not technically close #708 , but it does keep #708 from blocking #663

@ilaflott ilaflott mentioned this pull request Jan 30, 2026
Open
@ilaflott
Copy link
Member Author

ilaflott commented Jan 30, 2026

apparently, using numpy=2.* will be a bigger transition than i thought, so this PR will keep the numpy==1.26.* pin for now. spun up issue #711 to track the friction

@ilaflott
put env name back to fre-cli, bring the meta.yaml specs up to snuff w…
2cbe750 
…ith the environment yaml
@ilaflott
add conditional skips to fregrid dependent tests. specify build meta …
56a8f29 
…and backend tools to try and address conda package build error
@ilaflott
import pytest for mark.skipif
111f0f8
@ilaflott
light whitespace cleanup allfiles, adjust spacing of test_regrid_xy, …
327edf1 
…add assert where it was missing and add a doc string here or there, clean up some commented out code, add some more helpful assert-failure statements
@codecov
Copy link

codecov bot commented Jan 30, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.85%. Comparing base (70513c0) to head (31a3b10).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #707      +/-   ##
==========================================
- Coverage   85.35%   82.85%   -2.50%     
==========================================
  Files          68       68              
  Lines        4520     4520              
==========================================
- Hits         3858     3745     -113     
- Misses        662      775     +113
Flag Coverage Δ
unittests 82.85% <ø> (-2.50%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ilaflott ilaflott marked this pull request as ready for review January 30, 2026 19:08
@ilaflott ilaflott requested a review from ceblanton January 30, 2026 19:08
@ilaflott
Copy link
Member Author

ilaflott commented Jan 30, 2026

Note that this includes changes that are breaking for test_cloud_runner workflows in NOAA-GDFL/fre-workflows

Copilot AI mentioned this pull request Jan 30, 2026
Merged
8 tasks
Copilot AI added a commit that referenced this pull request Jan 30, 2026
@ilaflott
Add comprehensive documentation for PR #707 dependency changes
a818718 
Co-authored-by: ilaflott <6273252+ilaflott@users.noreply.github.com>
@ilaflott
Document PR #707 dependency changes: Python >=3.11, fregrid unbundled (…
31a3b10 
…#712)

* Initial plan

* Add comprehensive documentation for PR #707 dependency changes

Co-authored-by: ilaflott <6273252+ilaflott@users.noreply.github.com>

* Update regrid_xy README: Python >=3.11, fregrid no longer bundled

Co-authored-by: ilaflott <6273252+ilaflott@users.noreply.github.com>

* Add optional fre-nctools loading instructions to setup sections

Co-authored-by: ilaflott <6273252+ilaflott@users.noreply.github.com>

* Revise fre-nctools loading instructions in README

Updated instructions for loading fre-nctools and added notes on installation options.

* Add optional fre-nctools loading instructions to docs/ setup sections

Co-authored-by: ilaflott <6273252+ilaflott@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: ilaflott <6273252+ilaflott@users.noreply.github.com>
@ilaflott ilaflott mentioned this pull request Jan 30, 2026
Open
ceblanton
ceblanton reviewed Jan 30, 2026
View reviewed changes
meta.yaml
- conda-forge::metomi-rose
- conda-forge::nccmp
- conda-forge::numpy=1.26.*
- conda-forge::numpy==1.26.4
Copy link
Collaborator

@ceblanton ceblanton Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this be >= instead or must numpy be exactly that version?

Copy link
Member Author

@ilaflott ilaflott Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exact for now. v2 or more creates significant failures throughout the package

Copy link
Collaborator

@ceblanton ceblanton Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about an inline comment for why numpy has to be this exact presently? Someone will wonder in the future as we'll eventually want to use a more recent numpy.

ceblanton
ceblanton approved these changes Jan 30, 2026
View reviewed changes
Copy link
Collaborator

@ceblanton ceblanton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and I'm using it while testing fre-workflows so it's very likely safe.

@ilaflott ilaflott merged commit 618e622 into main Jan 31, 2026
5 of 6 checks passed
@ilaflott ilaflott deleted the use-other-cmor-version branch January 31, 2026 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ceblanton ceblanton ceblanton approved these changes

Assignees

@ilaflott ilaflott

Labels

bug Something isn't working clean up priority: HIGH

Projects

None yet

Milestone

No milestone

3 participants

@ilaflott @ceblanton